Skip to content

OTA binary files header/lzss handling #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Apr 29, 2024
Merged

Conversation

rjtokenring
Copy link
Collaborator

Motivation

Introducing new commands to handle OTA binary file header

  • PR address a single concern.
  • PR title and description are properly filled.
  • Changes will be merged in main.
  • Changes are covered by tests.
  • Logging is meaningful in case of troubleshooting.
  • History is clean, commit messages are meaningful (see CONTRIBUTING.md) and are well formatted.

@per1234 per1234 added the enhancement New feature or request label Feb 6, 2024
@rjtokenring rjtokenring force-pushed the encode-ota-binary-file branch from ac46944 to 52b46ce Compare April 23, 2024 15:03
This reverts commit 52b46ce.
@@ -0,0 +1,68 @@
// This file is part of arduino-cloud-cli.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there is a typo in the file name

Copy link
Collaborator Author

@rjtokenring rjtokenring Apr 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, found it. Fixed.

@rjtokenring rjtokenring merged commit 4db92cc into main Apr 29, 2024
11 checks passed
@rjtokenring rjtokenring deleted the encode-ota-binary-file branch April 29, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants